Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn on repo setting: Require sign-off on web-based commits #51

Open
a-fox opened this issue Oct 26, 2022 · 1 comment
Open

Turn on repo setting: Require sign-off on web-based commits #51

a-fox opened this issue Oct 26, 2022 · 1 comment
Assignees
@elisatrevino
Labels
priority: high It is important for the group to resolve this issue soon. status: needs-review type: admin This issue requires an action by an admin.

Comments

@a-fox
Copy link
Contributor

a-fox commented Oct 26, 2022

Many people making pull requests on the github web interface, and we have sign-off requirement on. To reduce merge errors, we need to enable web-based commit sign-off setting. It's in repo Settings => General. Guide link here.
@a-fox a-fox added priority: critical Progress on this issue is critical to the group's forward progress. type: admin This issue requires an action by an admin. status: needs-review labels Oct 26, 2022
@a-fox a-fox added priority: high It is important for the group to resolve this issue soon. and removed priority: critical Progress on this issue is critical to the group's forward progress. labels Oct 26, 2022
@a-fox
Copy link
Contributor Author

a-fox commented Oct 27, 2022

I just realised that due to our PR-process, the ToIP repo settings don't affect our commits in forks. Still, it's important to ensure that any commits we do in the main repo will be signed off as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@elisatrevino elisatrevino

Labels
priority: high It is important for the group to resolve this issue soon. status: needs-review type: admin This issue requires an action by an admin.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@a-fox @elisatrevino