Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCS Project structure #766

Closed
Tracked by #756
rolsonquadras opened this issue Aug 16, 2022 · 1 comment
Closed
Tracked by #756

VCS Project structure #766

rolsonquadras opened this issue Aug 16, 2022 · 1 comment
Assignees
Labels
Milestone

Comments

@rolsonquadras
Copy link
Member

rolsonquadras commented Aug 16, 2022

Here is the proposed VCS Repo structure proposal based on discussion between @aholovko @vkubiv @sudeshrshetty @DRK3 and @rolsonquadras

  • Use OpenAPI as the source of truth -> easy to document and share; build Golang stubs for rest controller.
  • Split code into 3 layers - rest controller, service (business logic) and database
  • Use VCS-specific database packages (not Aries DB providers) - initially support MongoDB v4 APIs to support AWS DocumentDB; add new DB implementation based on requirements later.
  • DB Upgradability - bundle database schema (if required), db indexing, and migration scripts outside the application
@rolsonquadras
Copy link
Member Author

rolsonquadras commented Aug 30, 2022

  • Use OpenAPI as the source of truth -> easy to document and share; build Golang stubs for rest controller.

Added as part of https://github.com/trustbloc/vcs/pull/772/files#diff-6c08e65eef0374988297d041bd50f87b385613a7e478c3812cb5312cc3e1f1e3

  • Split code into 3 layers - rest controller, service (business logic) and database

Added as part of https://github.com/trustbloc/vcs/pull/767/files

  • Use VCS-specific database packages (not Aries DB providers) - initially support MongoDB v4 APIs to support AWS DocumentDB; add new DB implementation based on requirements later.

Updated aries as part of https://github.com/trustbloc/vcs/pull/758/files. The new KMS store implementation will be part of Issuer management profile.

  • DB Upgradability - bundle database schema (if required), db indexing, and migration scripts outside the application

Created a separate issue #774

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants