Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.21.0-rc5 wrong http method with WS #883

Closed
johansmitsnl opened this issue Oct 6, 2024 · 4 comments · Fixed by #884
Closed

0.21.0-rc5 wrong http method with WS #883

johansmitsnl opened this issue Oct 6, 2024 · 4 comments · Fixed by #884
Labels
bug Something isn't working

Comments

@johansmitsnl
Copy link
Contributor

In the rc5 release I get the error:

ERROR error establishing WebSocket connection to backend ws://[::1]:8000/api/v1/ws for proxy error=Protocol(WrongHttpMethod)

I have config:

[[proxy]]
backend = "ws://[::1]:8000/api/v1/ws"
request_headers = { "host" = "example.org" }
ws = true

With the rc4 version it works fine.

@ctron ctron added the bug Something isn't working label Oct 7, 2024
@ctron
Copy link
Collaborator

ctron commented Oct 7, 2024

Yup, that was me. Sorry.

@ctron
Copy link
Collaborator

ctron commented Oct 7, 2024

Hm, I can't reproduce the issue though. There's a wrong HTTP method being provided to the internal function creating the request. However, that actually get overridden with GET, and that's what I see on the wire.

Can you provide some more detail, logs, maybe a packet capture of the issue?

@ctron
Copy link
Collaborator

ctron commented Oct 7, 2024

Ok, I should have sniffed the connection between trunk and the backend, not the WS client and the backend 🤣 … So I can reproduce it, and there's a PR fixing this: #884

@ctron ctron closed this as completed in #884 Oct 7, 2024
@ctron ctron closed this as completed in 5e9c178 Oct 7, 2024
@johansmitsnl
Copy link
Contributor Author

I can confirm that the new rc6 release fixed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants