Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XDC Network integration #27

Open
vrushalipanchal opened this issue Jun 26, 2024 · 8 comments · Fixed by #28
Open

XDC Network integration #27

vrushalipanchal opened this issue Jun 26, 2024 · 8 comments · Fixed by #28
Assignees

Comments

@vrushalipanchal
Copy link
Contributor

Hello Team,

We have cloned the "Marketplace" repository (https://github.com/truflation/marketplace) and made changes related to the XDC Apothem network. We are using Node 18.16.0.

When running the "yarn build" command, we encountered dependency errors:

  • @nomicfoundation/hardhat-ethers@^3.0.0
  • @typechain/ethers-v6

WhatsApp Image 2024-06-26 at 4 20 47 PM

WhatsApp Image 2024-06-26 at 4 22 05 PM

We added these dependencies using the following commands:

  • yarn add @nomicfoundation/hardhat-ethers@^3.0.0
  • yarn add @typechain/ethers-v6

After this, when we executed the "yarn test" command, we received the error "Command failed with exit code 1."

WhatsApp Image 2024-06-26 at 4 23 08 PM

Please look into this and let us know the next steps.

Additionally, could you please share any other network reference PR to add the XDC Network?

Thank you.

@joequant
Copy link
Contributor

joequant commented Jul 4, 2024

Try now. I put in changes that will have it compile cleanly on Ubuntu 22.04 with Node 20

Also for PR, I think that its a matter of just modifying the hardhat config file to include a new network chain id. Once that's hadded the hardhat can deploy the contracts to the new network.

@joequant joequant linked a pull request Jul 4, 2024 that will close this issue
@joequant joequant changed the title Dependency Errors and Test Failures while adding XDC Network XDC Network integration Jul 11, 2024
@joequant
Copy link
Contributor

@joequant
Copy link
Contributor

@vrushalipanchal I've created some changes that will let you pull data from truflation and set the blockchain. Look at the new-blockchain-howto.md document

@Dev-Doggo
Copy link

@joequant I'm not really the right person to handle this, I haven't deployed the marketplace stuff at all 🤷‍♂️

@zolotokrylin
Copy link

@Jarryd-pretorius was this complete?

@Jarryd-pretorius
Copy link

@Jarryd-pretorius was this complete?

I dont really know what this is about to be honest, the marketplace repo has not been touched in 5 months and I have heard nothing more regarding this. I suggest we just cancel this @zolotokrylin

@zolotokrylin
Copy link

zolotokrylin commented Oct 7, 2024

@Jarryd-pretorius, I asked @srust99. Let's see, if he doesn't know about this issue, we cancel it.

@Jarryd-pretorius
Copy link

@Jarryd-pretorius, I asked @srust99. Let's see, if he doesn't know about this issue, we cancel it.

Ok no worries sounds good @zolotokrylin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants