Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

The contract and deployer packages read different settings to get a user-specified registry address #5997

Closed
haltman-at opened this issue Apr 14, 2023 · 1 comment

Comments

@haltman-at
Copy link
Contributor

haltman-at commented Apr 14, 2023

Issue

See also: trufflesuite/trufflesuite.com#1420

When looking for a user-specified registry adress, the deployer and contract packages check different locations. Truffle Contract checks config.ens.registryAddress. However, the deployer checks config.network_config.registry.address (i.e., config.networks[config.network].registry.address).

This should be made consistent. In order to do this in a nonbreaking way, presumably both packages should check both locations, with one of them given priority over the other.

(Potentially also, registry and registryAddress could be made synonyms in both locations?)

Environment

  • Truffle version (truffle version): 5.8.2
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant