From 299cb3b199473381f730ad5c4e226e30c6b5e0bc Mon Sep 17 00:00:00 2001
From: Evgeny Stepanovych <undsoft@gmail.com>
Date: Wed, 3 Jul 2024 17:13:42 +0200
Subject: [PATCH] NAS-129883: Do not show Delete button for immutable users
 (#10277)

---
 .../user-details-row.component.html           | 19 ++++++++++---------
 .../user-details-row.component.spec.ts        |  7 +++++++
 .../user-details-row.component.ts             |  5 +++--
 3 files changed, 20 insertions(+), 11 deletions(-)

diff --git a/src/app/pages/account/users/user-details-row/user-details-row.component.html b/src/app/pages/account/users/user-details-row/user-details-row.component.html
index ffdef688038..6209748fdf3 100644
--- a/src/app/pages/account/users/user-details-row/user-details-row.component.html
+++ b/src/app/pages/account/users/user-details-row/user-details-row.component.html
@@ -9,15 +9,16 @@
   </button>
 
   <ng-container *ixRequiresRoles="[Role.AccountWrite]">
-    <button
-      *ngIf="!user().builtin"
-      mat-button
-      [ixTest]="['delete', user().username]"
-      (click)="doDelete(user())"
-    >
-      <ix-icon name="delete"></ix-icon>
-      <span>{{ 'Delete' | translate }}</span>
-    </button>
+    @if (!user().immutable) {
+      <button
+        mat-button
+        [ixTest]="['delete', user().username]"
+        (click)="doDelete(user())"
+      >
+        <ix-icon name="delete"></ix-icon>
+        <span>{{ 'Delete' | translate }}</span>
+      </button>
+    }
   </ng-container>
 
   <button
diff --git a/src/app/pages/account/users/user-details-row/user-details-row.component.spec.ts b/src/app/pages/account/users/user-details-row/user-details-row.component.spec.ts
index 506888f5916..f7cda68ad5d 100644
--- a/src/app/pages/account/users/user-details-row/user-details-row.component.spec.ts
+++ b/src/app/pages/account/users/user-details-row/user-details-row.component.spec.ts
@@ -106,6 +106,13 @@ describe('UserDetailsRowComponent', () => {
     );
   });
 
+  it('does not show Delete button for an immutable user', async () => {
+    spectator.setInput('user', { ...dummyUser, immutable: true });
+
+    const deleteButton = await loader.getHarnessOrNull(MatButtonHarness.with({ text: /Delete/ }));
+    expect(deleteButton).toBeNull();
+  });
+
   it('should open DeleteUserDialog when Delete button is pressed', async () => {
     const deleteButton = await loader.getHarness(MatButtonHarness.with({ text: /Delete/ }));
     await deleteButton.click();
diff --git a/src/app/pages/account/users/user-details-row/user-details-row.component.ts b/src/app/pages/account/users/user-details-row/user-details-row.component.ts
index 8d84df04adf..7ae1a91b06e 100644
--- a/src/app/pages/account/users/user-details-row/user-details-row.component.ts
+++ b/src/app/pages/account/users/user-details-row/user-details-row.component.ts
@@ -1,5 +1,6 @@
 import {
-  Component, ChangeDetectionStrategy, EventEmitter, Output, input,
+  Component, ChangeDetectionStrategy, input,
+  output,
 } from '@angular/core';
 import { MatDialog } from '@angular/material/dialog';
 import { Router } from '@angular/router';
@@ -24,7 +25,7 @@ import { UrlOptionsService } from 'app/services/url-options.service';
 })
 export class UserDetailsRowComponent {
   readonly user = input.required<User>();
-  @Output() delete = new EventEmitter<number>();
+  readonly delete = output<number>();
 
   protected readonly Role = Role;