Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test cases for pbft-core funcs #29

Open
arcolife opened this issue Jul 10, 2018 · 0 comments
Open

test cases for pbft-core funcs #29

arcolife opened this issue Jul 10, 2018 · 0 comments
Assignees
@samikshan @arcolife @hixichen
Labels
A-level non trivial issues with high difficulty or repo maintainers help wanted Extra attention is needed
Milestone
Alpha 1

Comments

@arcolife
Copy link
Collaborator

arcolife commented Jul 10, 2018 •
edited
Loading

Need to integrate with Travis CI / Jenkins.

A highly disrupted dev cycle led us to a dark dark place, one without test cases.

Need to push for *_test.go files, just like https://github.com/truechain/truechain-consensus-core/blob/devel/pbft/src/pbft-core/config/config_test.go

cc/ @samikshan @hixichen
@arcolife arcolife added the help wanted Extra attention is needed label Jul 10, 2018
@arcolife arcolife added this to the Alpha 2 milestone Jul 10, 2018
@arcolife arcolife modified the milestones: Alpha 2, Alpha 1 Jul 16, 2018
@arcolife arcolife mentioned this issue Jul 20, 2018
Closed
@arcolife arcolife added B-level slightly non-trivial with intermediate difficulty A-level non trivial issues with high difficulty or repo maintainers and removed B-level slightly non-trivial with intermediate difficulty labels Jul 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samikshan samikshan

@arcolife arcolife

@hixichen hixichen

Labels
A-level non trivial issues with high difficulty or repo maintainers help wanted Extra attention is needed
Projects
None yet
Milestone
Alpha 1
Development

No branches or pull requests
3 participants
@samikshan @arcolife @hixichen