Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Suggestion] Use .all-contributorsrc file to render contributors #6

Open
stavros-k opened this issue Dec 1, 2024 · 3 comments
Open
Labels
⏫ enhancement New feature or request 🏯 styles Stylesheets or design updates

Comments

@stavros-k
Copy link

Example file:

https://github.com/wailsapp/wails/blob/master/.all-contributorsrc

Example output of all-contributors generated html:
https://github.com/wailsapp/wails/blob/dade880064ee6c9ffdbd311d223628abbaf090ca/website/src/pages/credits.mdx?plain=1#L16-L258

@trueberryless
Copy link
Member

Thank you for your feedback on this plugin!

To elaborate your idea a little bit more, you mean that the plugin adds an option which changes the behaviour a little bit. It should get the contributor information from the .all-contributorsrc file and display this grid like table instead of the list as it is of right now. Do you know if the rendering of the HTML is handled by the bot or does the rendering need to be done within this plugin?

I generally think this is a good idea because it seems that the all-contributor repository is a well-known standard in terms of contributions.

Are you open to create a Pull Request with the implementation of these changes? Otherwise it will probably take me a while to get back to this issue and implement the suggesteion...

@stavros-k
Copy link
Author

The bot does generate the html, but I don't like the table html as it's hard to make it responsive on multiple screen sizes.
A flex-box is probably a much better way to deal with this. So I believe if this gets added, we should render html.

Yeah! all-contributor is indeed used in many places.
BTW you can find the icons they use here https://allcontributors.org/docs/en/emoji-key
We can probably find in their repo how they generate different links for each "type" of icon.
eg for bugs they have a link to github issues, filter by the author name, for code they have the same for pull requests etc

To be honest, while it would be fun to try do this, my plate is currently more full that I would like to admit :P
And my css skills is on the negative side!

@trueberryless trueberryless added ⏫ enhancement New feature or request 🏯 styles Stylesheets or design updates labels Dec 1, 2024
@TeenBiscuits
Copy link

That would be amazing. I also use .all-contributorsrc for the contributions in my page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
⏫ enhancement New feature or request 🏯 styles Stylesheets or design updates
Projects
None yet
Development

No branches or pull requests

3 participants