Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boxes on score measure aren't in the right place #25

Open
alastair opened this issue Jul 26, 2021 · 2 comments
Open

boxes on score measure aren't in the right place #25

alastair opened this issue Jul 26, 2021 · 2 comments
Labels
temp-fix temporary fix that needs further dev

Comments

@alastair
Copy link
Member

When we added the navigation menu bar to the top of the app and moved the position of the score div, the boxes that we use to draw around a measure to say that there are annotations have ended up in the wrong place.

A few improvements that we can make to this:

  • Ensure that the <SelectableScoreApp> component renders all of its children inside a bootstrap grid layout (Interface overhaul #15)
  • Try and see if we can identify the top of page offset of the score svg automatically, so that we can draw the boxes in the right place regardless of the score's position
  • In order to make the SelectableScoreApp component easier to understand and follow, it'd be good to move the code that does the annotation processing and box drawing into a set of well defined utility functions, in order to make it easier to understand what the code is doing and separate each specific sub-part.
@fedezubo
Copy link
Contributor

As a temp fix I can try and see what's causing the issue but I agree that the selectablescore file needs reshaping

@fedezubo fedezubo added the temp-fix temporary fix that needs further dev label Jul 28, 2021
@alastair
Copy link
Member Author

I was reading about React Portals, which seems to be a great way of sending messages between unconnected react components. Or Refs might be a way of passing messages from a highlight box to the rest of the app to select the relevant annotation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
temp-fix temporary fix that needs further dev
Projects
None yet
Development

No branches or pull requests

2 participants