Merge pull request #9 from hckrnews/feature/array-with-object-diff

Finetune dif and intersect

Author: w3nl

package-lock.json

@@ -1,6 +1,6 @@
 {
     "name": "@hckrnews/arrays",
-    "version": "2.1.1",
+    "version": "2.1.2",
     "description": "Usefull array helpers.",
     "files": [
         "src/helpers.js",

package.json

@@ -9,8 +9,7 @@ class Diff {
 
     get differenceArray() {
         return this.currentArray.filter(
-            (value) =>
-                toJson(this.otherArray).indexOf(JSON.stringify(value)) < 0
+            (value) => !toJson(this.otherArray).includes(JSON.stringify(value))
         );
     }
 
@@ -21,7 +20,7 @@ class Diff {
 
         return this.otherArray.filter(
             (value) =>
-                toJson(this.currentArray).indexOf(JSON.stringify(value)) < 0
+                !toJson(this.currentArray).includes(JSON.stringify(value))
         );
     }
 

src/modules/diff.js

@@ -6,7 +6,7 @@ export default function intersect(original, array, multi) {
 
         if (multi) {
             const found = jsonValue.reduce((accumulator, currentValue) => {
-                if (currentValue.indexOf(JSON.stringify(value)) >= 0) {
+                if (currentValue.includes(JSON.stringify(value))) {
                     return accumulator + 1;
                 }
 
@@ -16,6 +16,6 @@ export default function intersect(original, array, multi) {
             return found === array.length;
         }
 
-        return jsonValue.indexOf(JSON.stringify(value)) >= 0;
+        return jsonValue.includes(JSON.stringify(value));
     });
 }

src/modules/intersect.js

@@ -9,7 +9,7 @@ class Match {
 
     check(value) {
         if (Array.isArray(this.find)) {
-            return this.checkOperators(value, this.find.indexOf(value) < 0);
+            return this.checkOperators(value, !this.find.includes(value));
         }
 
         return this.checkOperators(value, String(value) !== String(this.find));