-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: Upgrade to 2.5.2: Default mark interval sometimes buggy #70
Comments
When filing an issue report. Please include in the description what you believe to be the issue. What may be obvious to you is maybe not obvious to others. |
In the initial example the first In the next example the first And in the final example the first I wouldn't expect such short actual intervals. |
It seems that at least messages from I should have already mentioned that yesterday but those |
Since I don't use MARK in my setups at all, the following is a speculative patch: diff --git a/src/syslogd.c b/src/syslogd.c
index 68040fe..e0a637f 100644
--- a/src/syslogd.c
+++ b/src/syslogd.c
@@ -1679,8 +1679,22 @@ static void logmsg(struct buf_msg *buffer)
/* don't output marks to recently written files */
if (buffer->flags & MARK) {
- if (timer_now() - f->f_time < MarkInterval)
+ switch (f->f_type) {
+ case F_CONSOLE:
+ case F_FILE:
+ case F_FORW:
+ case F_PIPE:
+ case F_TTY:
+ case F_USERS:
+ case F_WALL:
+ /* relevant log targets that set f->f_time */
+ if ((timer_now() - f->f_time) < MarkInterval)
+ continue;
+ break;
+ default:
+ /* skip --MARK-- for other log targets */
continue;
+ }
}
/* |
@troglobit: Thanks but unfortunately it didn't help:
|
OK, that's unfortunate, because I cannot reproduce your issue at all. Is there anything special about your configuration you can think of? |
Most probably just |
OK. So no pipes or alerting users pure similar odd stuff then. Alright. And you're on Slackware, right, with a custom kernel? |
Indeed. |
Just for sure: Have you used any 32-bit system too when trying to reproduce? |
No. All 32-bit systems have aged out in all my environments. |
DISCLAIMER: Nothing fatal, just nice to become fixed if confirmed. :-)
Upgrade from 2.5.0:
Upgrade from 2.3.0:
Another upgrade from 2.3.0:
First and third
-- MARK --
in the very last example may relate tosysklogd/man/syslogd.8
Lines 627 to 641 in 3332c55
The text was updated successfully, but these errors were encountered: