Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor rhs! to move data copying outside of iteration loop #13

Open
huiyuxie opened this issue May 13, 2024 · 0 comments · May be fixed by #63
Open

Refactor rhs! to move data copying outside of iteration loop #13

huiyuxie opened this issue May 13, 2024 · 0 comments · May be fixed by #63
Assignees
@huiyuxie
Labels
high priority Things with high priority performance Improve performance

Comments

@huiyuxie
Copy link
Collaborator

The data copying of du and u is done inside loops when calling rhs!. This lowers performance due to the overhead of copying data from the CPU to the GPU and back. A better approach would be to move this process outside of the loops.
@huiyuxie huiyuxie added the enhancement New feature or request label May 13, 2024
@huiyuxie huiyuxie self-assigned this May 13, 2024
@huiyuxie huiyuxie added the high priority Things with high priority label Aug 22, 2024
@huiyuxie huiyuxie added performance Improve performance and removed enhancement New feature or request labels Sep 3, 2024
@huiyuxie huiyuxie linked a pull request Oct 8, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@huiyuxie huiyuxie

Labels
high priority Things with high priority performance Improve performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Parallelization for computing coefficients trixi-gpu/TrixiCUDA.jl
1 participant
@huiyuxie