Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date sorting bug in dialog.php version PHP 8 #734

Open
winr777 opened this issue Mar 16, 2024 · 0 comments
Open

Date sorting bug in dialog.php version PHP 8 #734

winr777 opened this issue Mar 16, 2024 · 0 comments

Comments

@winr777
Copy link

winr777 commented Mar 16, 2024

Hi,
I saw that with or without the parameter in the url "&sort_by=date" the files were not properly sorted by date.
So I modified the following line in dialog.php version PHP 8:

? $x['date'] <=> $y['date'] : $y['date'] <=> $x['date'];

by the lines

? $x['date'] < $y['date'] : $y['date'] >= $x['date'];

I think it should also be modified on the lines 904 "size" and lines 920 "extension" .

good day to all

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant