Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error Upload file PHP 8.2.4 #718

Open
bbabolinia69 opened this issue Jul 17, 2023 · 3 comments
Open

Error Upload file PHP 8.2.4 #718

bbabolinia69 opened this issue Jul 17, 2023 · 3 comments

Comments

@bbabolinia69
Copy link

image

I have done the steps given in the previous issue, but the problem still occurs in PHP 8.2.4

@jshster
Copy link

jshster commented Jul 20, 2023

Do you know how to review your PHP error logs? I've faced an issue with the php_image_magician.php file where there is a number conversion error (float to int or the other way). I've resolved this by adding a "floor" or "ceil" call depending on your preference so that the value passed is always an INT.

@bbabolinia69
Copy link
Author

thanks for the help, but I haven't solved the problem yet. I will learn more about this issue

@dleffler
Copy link

dleffler commented Feb 1, 2024

Not yet fixed in the code here. Though there's fixes above the main error is in /include/php_image_magician.php whereby the floating point parameters ($cropStartX & $cropStartY are not recommended for the imagecopyresampled() call. I added an '(int)' type cast to each parameter and the 'warning' no longer spits out which causes the above error. (See #709)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants