Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend dependencies audit #23753

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

glebcha
Copy link

@glebcha glebcha commented Oct 11, 2024

Description

This PR add frontend dependencies vulnerabilities audit both for current and preview ui.

Additional context and related issues

Original issue with proposal

Release notes

(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text:

Copy link

cla-bot bot commented Oct 11, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot added the ui Web UI label Oct 11, 2024
@glebcha glebcha force-pushed the feat/frontend-dependencies-audit branch from 5478ca8 to d00a8fe Compare October 11, 2024 10:21
Copy link

cla-bot bot commented Oct 11, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@glebcha glebcha force-pushed the feat/frontend-dependencies-audit branch from d00a8fe to 1a6f875 Compare October 11, 2024 10:23
Copy link

cla-bot bot commented Oct 11, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Copy link

github-actions bot commented Nov 1, 2024

This pull request has gone a while without any activity. Tagging the Trino developer relations team: @bitsondatadev @colebow @mosabua

@github-actions github-actions bot added the stale label Nov 1, 2024
Copy link

cla-bot bot commented Nov 5, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

@github-actions github-actions bot removed the stale label Nov 5, 2024
Copy link
Member

@ebyhr ebyhr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you fix CI failure?

Error:  Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.1:npm (package (webapp)) on project trino-web-ui: Failed to run task: 'npm run package:clean' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]

@glebcha
Copy link
Author

glebcha commented Nov 8, 2024

Could you fix CI failure?

Error:  Failed to execute goal com.github.eirslett:frontend-maven-plugin:1.15.1:npm (package (webapp)) on project trino-web-ui: Failed to run task: 'npm run package:clean' failed. org.apache.commons.exec.ExecuteException: Process exited with an error: 1 (Exit value: 1) -> [Help 1]

Sure, will check!

Copy link

cla-bot bot commented Nov 8, 2024

Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to [email protected]. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ui Web UI
Development

Successfully merging this pull request may close these issues.

3 participants