Add TPC plan verification tests for iceberg #23507
Open
+20,047
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These tests are useful for figuring out the potential impact of planner changes on TPC benchmarks. They are useful for assessing different approches in optimizer rules during the development phase. These also help with assessing metadata accesses and planner bottlenecks for complex queries. These also provide test coverage for a variety of query plans that are not necessarily covered by existing unit tests.
raunaqmorarka
requested review from
martint,
wendigo,
electrum,
losipiuk and
sopel39
wendigo
approved these changes
Sep 19, 2024
sopel39
approved these changes
Sep 20, 2024
|
nice. thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
These tests are useful for figuring out the potential impact of planner changes on TPC benchmarks. They are useful for assessing different approches in optimizer rules during the development phase. These also help with assessing metadata accesses and planner bottlenecks for complex queries.
These also provide test coverage for a variety of query plans that are not necessarily covered by existing unit tests.
Additional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: