Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent use of theme variables #8

Open
asafpm opened this issue Nov 26, 2018 · 1 comment
Open

Inconsistent use of theme variables #8

asafpm opened this issue Nov 26, 2018 · 1 comment

Comments

@asafpm
Copy link

asafpm commented Nov 26, 2018

In templates/partials/navigation.html.twig the theme variables are used inconsistently. For example at the top of the file there is

{% set navbar_style = theme_var('navbar_style') %}
{% set navbar_bgcolor = theme_var('navbar_bgcolor') %}

while another theme variable is used as:

config.themes.bootstrap4.dropdown.enabled

This creates problems when making inherited themes based on bootstrap4 because navbar_style and navbar_bgcolor are loaded from the inherited theme while config.themes.bootstrap4.dropdown.enabled is loaded from the parent bootstrap4 theme.

@mfi-teresa
Copy link
Contributor

submitted PR to fix this (surprised no one else has) - change config.themes.bootstrap4.dropdown.enabled
to
theme.dropdown.enabled
and it fixes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants