Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: The addition of Keycloak support or user defined provider #23

Open
mannp opened this issue Jul 23, 2019 · 5 comments
Open

Comments

@mannp
Copy link

mannp commented Jul 23, 2019

Hi there

Thanks for your consideration.

This is the link for Keycloak support via the League/oauth2-client

-> https://github.com/stevenmaguire/oauth2-keycloak

@chhemme
Copy link

chhemme commented Nov 16, 2021

Any Feedback on this?

@ozfox
Copy link

ozfox commented Nov 16, 2021

I wanted to answer on this since a while, so thank you @chhemme for motivating me. I was looking for the Keycloak support a while ago and ended up with forking grav-plugin-login-oauth2-extras and adding a custom Keycloak provider. It does actually use the library mentioned in the original post.

It works stable in my specific usecase since a while but I never found the time to implement all functionality or clean it up. Unfortunately my time to work on this is limited right now but I can at least publish my effort and create a PR. Maybe someone can pick it up or the maintainers can point out what's missing.

Won't happen this week I guess, but I'll try.

@chhemme
Copy link

chhemme commented Nov 17, 2021

Thanks @ozfox
That would be great if you could create PR when you find time for it.

@ozfox
Copy link

ozfox commented Feb 28, 2022

The Keycloak support was implemented with the merge request Add Keycloak support #5 of the grav-plugin-login-oauth2-extras plugin. All credit goes to @andreasgrill, I am just referencing this here.

What's meant with "user defined provider" is not clear to me, I guess this already possible with the current API and is exactly what the grav-plugin-login-oauth2-extras plugin is doing?!

Guess this can be closed if a new version of login-oauth2-extras is released.

@mannp
Copy link
Author

mannp commented Mar 5, 2022

It means any other oidc compatible provider.

I no longer use grav, so this can be closed for me, or left open to track the item?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants