Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Does this plugin handle concurrent file access - are the CRUD operations atomic? #72

Open
NicoHood opened this issue Sep 29, 2020 · 1 comment
Assignees
Labels
enhancement Enhancement for an existing feature

Comments

@NicoHood
Copy link
Contributor

Hey there,
I was recently wondering if the comments plugin is robust against parallel read/write operations (two people commenting at the same time). To me it seems it is not, and I am searching for a future proof way to handle this issue.

My first idea was to use the database plugin with sqlite, but then I stumbled across the flex objects plugin. Since it says it implements CRUD, does this mean all concurrent operations on the underlying file are handled by the plugin? If yes, that is great and should be added more explicit to the readme.

Cheers

@mahagr
Copy link
Contributor

mahagr commented Oct 7, 2020

It really depends on the backend used for the storage. If you store comments on separate files (or create db backend) it'll be atomic. On a single file, it does lock the file, but not long enough to be atomic.

@mahagr mahagr self-assigned this Oct 7, 2020
@mahagr mahagr added the enhancement Enhancement for an existing feature label Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement for an existing feature
Projects
None yet
Development

No branches or pull requests

2 participants