Skip to content

Commit ba21152

Browse files
committed
Fix for ember-bootstrap v5.1
Was throwing with `Assertion Failed: <PowerSelect> requires an `@onChange` function` as the components still referred to properties on `this` that don't exist anymore since ember-bootstrap/ember-bootstrap#1772. See failing [CI](https://github.com/kaliber5/ember-bootstrap-power-select/runs/6518834502?check_suite_focus=true#step:5:312)
1 parent 4d18579 commit ba21152

File tree

4 files changed

+31
-12
lines changed

4 files changed

+31
-12
lines changed

addon/components/bs-form/element/control/power-select-multiple.hbs

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
@afterOptionsComponent={{@afterOptionsComponent}}
44
@allowClear={{@allowClear}}
55
@animationEnabled={{@animationEnabled}}
6-
@ariaDescribedBy={{this.ariaDescribedBy}}
6+
@ariaDescribedBy={{@ariaDescribedBy}}
77
@ariaInvalid={{@ariaInvalid}}
88
@ariaLabel={{@ariaLabel}}
99
@ariaLabelledBy={{@ariaLabelledBy}}
@@ -27,7 +27,7 @@
2727
@matchTriggerWidth={{@matchTriggerWidth}}
2828
@noMatchesMessage={{@noMatchesMessage}}
2929
@onBlur={{@onBlur}}
30-
@onChange={{this.onChange}}
30+
@onChange={{@onChange}}
3131
@onClose={{@onClose}}
3232
@onFocus={{@onFocus}}
3333
@onInput={{@onInput}}
@@ -45,7 +45,7 @@
4545
@searchField={{if (has-block) @searchField (if @searchField @searchField @optionLabelPath)}}
4646
@searchMessage={{@searchMessage}}
4747
@searchPlaceholder={{@searchPlaceholder}}
48-
@selected={{this.value}}
48+
@selected={{@value}}
4949
@selectedItemComponent={{@selectedItemComponent}}
5050
@tabindex={{@tabindex}}
5151
@triggerClass={{@triggerClass}}

addon/components/bs-form/element/control/power-select.hbs

+3-3
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
@afterOptionsComponent={{@afterOptionsComponent}}
44
@allowClear={{@allowClear}}
55
@animationEnabled={{@animationEnabled}}
6-
@ariaDescribedBy={{this.ariaDescribedBy}}
6+
@ariaDescribedBy={{@ariaDescribedBy}}
77
@ariaInvalid={{@ariaInvalid}}
88
@ariaLabel={{@ariaLabel}}
99
@ariaLabelledBy={{@ariaLabelledBy}}
@@ -27,7 +27,7 @@
2727
@matchTriggerWidth={{@matchTriggerWidth}}
2828
@noMatchesMessage={{@noMatchesMessage}}
2929
@onBlur={{@onBlur}}
30-
@onChange={{this.onChange}}
30+
@onChange={{@onChange}}
3131
@onClose={{@onClose}}
3232
@onFocus={{@onFocus}}
3333
@onInput={{@onInput}}
@@ -46,7 +46,7 @@
4646
@searchField={{if (has-block) @searchField (if @searchField @searchField @optionLabelPath)}}
4747
@searchMessage={{@searchMessage}}
4848
@searchPlaceholder={{@searchPlaceholder}}
49-
@selected={{this.value}}
49+
@selected={{@value}}
5050
@selectedItemComponent={{@selectedItemComponent}}
5151
@tabindex={{@tabindex}}
5252
@triggerClass={{@triggerClass}}

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -45,7 +45,7 @@
4545
"bootstrap": "^4.6.0",
4646
"broccoli-asset-rev": "^3.0.0",
4747
"ember-auto-import": "^2.4.1",
48-
"ember-bootstrap": "^5.0.0",
48+
"ember-bootstrap": "^5.1.0",
4949
"ember-cli": "~3.28.5",
5050
"ember-cli-dependency-checker": "^3.2.0",
5151
"ember-cli-inject-live-reload": "^2.1.0",

yarn.lock

+24-5
Original file line numberDiff line numberDiff line change
@@ -5178,10 +5178,10 @@ ember-auto-import@^2.2.3, ember-auto-import@^2.4.0, ember-auto-import@^2.4.1:
51785178
ember-style-modifier "^0.7.0"
51795179
ember-truth-helpers "^2.1.0 || ^3.0.0"
51805180

5181-
ember-bootstrap@^5.0.0:
5182-
version "5.0.0"
5183-
resolved "https://registry.yarnpkg.com/ember-bootstrap/-/ember-bootstrap-5.0.0.tgz#aa1de391d662cafebe7d715449853ccda9237a0f"
5184-
integrity sha512-ocH7qJKikxDgLv1prWyYzDaH85of8/l0LeV2bnMCp3/ZdRak/vq4dWqm53hMQ0ifN4llfs1Q1bwlcra/BT7yCA==
5181+
ember-bootstrap@^5.1.0:
5182+
version "5.1.0"
5183+
resolved "https://registry.yarnpkg.com/ember-bootstrap/-/ember-bootstrap-5.1.0.tgz#14c8603c87c9e1108811874ccbd2f65adcecf077"
5184+
integrity sha512-iIzn4iEY+fR+2gbVod+YFlrRDX2BeSFAOS7niIWHw02oQVxOd3Vjq9rH9f2F/FyZta/dDp5qf4mWlPsCXQg5XQ==
51855185
dependencies:
51865186
"@ember/render-modifiers" "^2.0.0"
51875187
"@embroider/macros" "^1.0.0"
@@ -5207,7 +5207,7 @@ ember-bootstrap@^5.0.0:
52075207
ember-popper-modifier "^2.0.0"
52085208
ember-ref-bucket "^4.0.0"
52095209
ember-render-helpers "^0.2.0"
5210-
ember-style-modifier "^0.7.0"
5210+
ember-style-modifier "^0.8.0"
52115211
findup-sync "^5.0.0"
52125212
fs-extra "^10.0.0"
52135213
resolve "^1.18.1"
@@ -5798,6 +5798,17 @@ ember-modifier@^3.0.0, ember-modifier@^3.1.0:
57985798
ember-cli-typescript "^5.0.0"
57995799
ember-compatibility-helpers "^1.2.5"
58005800

5801+
ember-modifier@^3.2.7:
5802+
version "3.2.7"
5803+
resolved "https://registry.yarnpkg.com/ember-modifier/-/ember-modifier-3.2.7.tgz#f2d35b7c867cbfc549e1acd8d8903c5ecd02ea4b"
5804+
integrity sha512-ezcPQhH8jUfcJQbbHji4/ZG/h0yyj1jRDknfYue/ypQS8fM8LrGcCMo0rjDZLzL1Vd11InjNs3BD7BdxFlzGoA==
5805+
dependencies:
5806+
ember-cli-babel "^7.26.6"
5807+
ember-cli-normalize-entity-name "^1.0.0"
5808+
ember-cli-string-utils "^1.1.0"
5809+
ember-cli-typescript "^5.0.0"
5810+
ember-compatibility-helpers "^1.2.5"
5811+
58015812
ember-named-blocks-polyfill@^0.2.4:
58025813
version "0.2.5"
58035814
resolved "https://registry.yarnpkg.com/ember-named-blocks-polyfill/-/ember-named-blocks-polyfill-0.2.5.tgz#d5841406277026a221f479c815cfbac6cdcaeecb"
@@ -5961,6 +5972,14 @@ ember-style-modifier@^0.7.0:
59615972
ember-cli-babel "^7.26.6"
59625973
ember-modifier "^3.0.0"
59635974

5975+
ember-style-modifier@^0.8.0:
5976+
version "0.8.0"
5977+
resolved "https://registry.yarnpkg.com/ember-style-modifier/-/ember-style-modifier-0.8.0.tgz#ef46b3f288e63e3d850418ea8dc6f7b12edde721"
5978+
integrity sha512-I7M+oZ+poYYOP7n521rYv7kkYZbxotL8VbtHYxLQ3tasRZYQJ21qfu3vVjydSjwyE3w7EZRgKngBoMhKSAEZnw==
5979+
dependencies:
5980+
ember-cli-babel "^7.26.6"
5981+
ember-modifier "^3.2.7"
5982+
59645983
ember-template-lint@^3.15.0:
59655984
version "3.16.0"
59665985
resolved "https://registry.yarnpkg.com/ember-template-lint/-/ember-template-lint-3.16.0.tgz#7af2ec8d4386f4726be08c14c39ba121c56f0896"

0 commit comments

Comments
 (0)