-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
before tournament 3 #374
Comments
contract based accounts can only do maximum 18MM gas whereas we're using the following manual estimate for gas:
where Currently the maximum number of proofs is 24 (1 + 2 + 3 + 8 + 10), which according to the calculation results in 39.6MM (although in reality the gas used in this tx is closer to 26 as reported by base wallet team). wrt times there are some constraints to consider. 2—4 body simulations (levels 1—3) consist of 10 sec chunks so we can't easily split them into 5 sec intervals like the suggested Another solution is to forgo the limitation of generating proofs in the browser. This is the restriction that has created the current 10s and 5 sec chunk limitations. One extreme would be to make a single proof per game that verified Instead of an extreme approach, we could also consider just changing the level 4 and level 5 prover to run I'll start trying this solution out. |
ok got a working version where with just a swap of the 5 sec chunks to 10 sec chunks. Tested without removing level 1 which would result in maximum 15. I think it's worth trying to deploy this solution in a non-disruptive way (no upgrade necessary) just to see if the base contract based wallets start working. |
update: successfully deployed the reduced proving system to live base mainnet, see a reduction of gas costs for longest possible number of proofs (15) reduced to estimate of 27MM (actually ~20MM) from previous amount of 39.6MM (not bad!) with no need to deploy full upgrade to the game logic. This is actually a pretty amazing improvement for the amount of disruption and only needing 3 hours of work! I'm going to checkpoint this work and make it live on the front end as well before continuing with the possible full upgrade that reduces the total number of levels and changes body size again. Open question is whether I try to combine the full upgrade (AnybodyProblemV3.sol) into a fix for the tournament since it's not currently tracking weekly play correctly atm. Since we're not allowing trustless prize deployment this isn't an issue and it's an open question whether we need this ever. |
to help improve gas estimate and understanding killing baddies (2 vs 1):
20s
25s
35s
40s
?? (note 4 levels) = 120 ??The text was updated successfully, but these errors were encountered: