Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-architect missile cancel system #368

Open
okwme opened this issue Oct 17, 2024 · 0 comments
Open

re-architect missile cancel system #368

okwme opened this issue Oct 17, 2024 · 0 comments

Comments

@okwme
Copy link
Member

okwme commented Oct 17, 2024

a couple times one player has turned up an invalid position x bug when submitting their final game. Every time I've gone through their player data I am unable to reproduce the error. What's essentially happening is that in the middle of one of the later rounds, a chunk uses invalid starting data to create a proof. For instance:

Level 4, chunk 1 ends with body 0 position x at 12345. JS and Circom agree when the game is replayed. However for some reason, in the live game, the player's version of JS thinks that body 0 ends at position 54321 (made up numbers to demonstrate point). This causes an error when the next chunk is run and solidity stores the circom results instead of the js results.

This could only happen if the user's version of JS is incorrectly calculating. OR if there is something else occuring that results in the JS thinking it has a different outcome. The most likely culprit is the missile removal system which has caused problems in the past.

Actually, now that generating the proofs as soon as possible is not so important thanks to Sindri, we postpone posting a level's missiles until the entire thing is complete. Then chunk them in the front end for the prover 🤔

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant