should pathways_cbd() be a function?

[PietrH]

Currently pathways_cbd() is a function that accepts no arguments, and always returns the same tibble. Woudn't it be better to include this tibble as a data object?

https://usethis.r-lib.org/reference/use_data.html

trias/R/pathways_cbd.R

Lines 1 to 77 in 98ef3f2

	#' Pathways of introdcution as defined by CBD
	#'
	#' Function to get all CBD pathays of introdution at level 1 (`pathway_level1`)
	#' and level 2 (`pathway_level2`). Added pathway `unknown` at level 1 and level
	#' 2 for classifying taxa without pathway (at level 1 or level 2) information.
	#'
	#' @return A tibble data.frame with 2 columns: `pathway_level1` and
	#' `pathway_level2`.
	#' @export
	#' @usage pathways_cbd()
	pathways_cbd <- function() pathwayscbd
	pathwayscbd <- dplyr::tibble(
	pathway_level1 = c(
	rep("release", 9),
	rep("escape", 13),
	rep("contaminant", 11),
	rep("stowaway", 12),
	rep("corridor", 3),
	rep("unaided", 2),
	"unknown"
	),
	pathway_level2 = c(
	"biological_control",
	"erosion_control",
	"fishery",
	"hunting",
	"landscape_improvement",
	"conservation",
	"use",
	"other",
	"unknown",
	"agriculture",
	"aquaculture",
	"zoo",
	"pet",
	"farm",
	"forestry",
	"fur_farm",
	"horticulture",
	"ornamental",
	"research",
	"food_bait",
	"other",
	"unknown",
	"nursery",
	"bait",
	"food",
	"on_animals",
	"animal_parasite",
	"on_plants",
	"plant_parasite",
	"seed",
	"timber",
	"habitat_material",
	"unknown",
	"fishing_equipment",
	"container",
	"airplane",
	"ship",
	"machinery",
	"people_luggage",
	"organic_packing",
	"ballast_water",
	"hull_fouling",
	"vehicles",
	"other",
	"unknown",
	"water",
	"land",
	"unknown",
	"natural_dispersal",
	"unknown",
	"unknown"
	)
	)

[damianooldoni]

You are right. I was in that time following rgbif's maintainer, Scott Chamberlain, which was using something similar. But you are right.

[PietrH]

Scott might have a good reason, I'd be interested to know the advantages of doing it this way.

Can we link this issue to a branch or PR? That way we don't lose track.

pathways_cbd perhaps?