feat(suite): quick-action refactotring, simplification of the UI and adding a update icon #14014
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peter-sanderson
force-pushed
the
quick-actions-refactoring
branch
from
2e80652
to
c8ebe6f
Compare
adamhavel
reviewed
Aug 29, 2024
peter-sanderson
force-pushed
the
quick-actions-refactoring
branch
8 times, most recently
from
af0d9c1
to
a88acab
Compare
peter-sanderson
commented
Aug 29, 2024
| @@ -0,0 +1,4 @@ | |||
| export const Update = () => { | |||
| // Todo: this will be implemented in future Pull Request | |||
| return <></>; | |||
There was a problem hiding this comment.
I will implement this in next PR. It will look like this
peter-sanderson
force-pushed
the
quick-actions-refactoring
branch
from
a88acab
to
5472a50
Compare
jvaclavik
reviewed
Aug 29, 2024
packages/components/src/components/ComponentWithSubIcon/ComponentWithSubIcon.tsx
Show resolved
Hide resolved
packages/components/src/components/ComponentWithSubIcon/ComponentWithSubIcon.stories.tsx
Show resolved
Hide resolved
packages/components/src/components/ComponentWithSubIcon/ComponentWithSubIcon.stories.tsx
Outdated
Show resolved
Hide resolved
packages/components/src/components/ComponentWithSubIcon/ComponentWithSubIcon.tsx
Outdated
Show resolved
Hide resolved
packages/suite/src/components/suite/layouts/SuiteLayout/Sidebar/QuickActions/CustomBackend.tsx
Outdated
Show resolved
Hide resolved
peter-sanderson
force-pushed
the
quick-actions-refactoring
branch
2 times, most recently
from
b0bab92
to
53cbe39
Compare
peter-sanderson
force-pushed
the
quick-actions-refactoring
branch
4 times, most recently
from
e58203f
to
3047b6d
Compare
jvaclavik
approved these changes
Aug 30, 2024
| const SubIconWrapper = styled.div<SubIconWrapperProps>` | ||
| position: absolute; | ||
|
|
||
| right: -${({ $subIconSize }) => $subIconSize / 2 + 3}px; |
|
|
||
| export const Update = () => { | ||
| const theme = useTheme(); | ||
| // const { translationString } = useTranslation(); |
peter-sanderson
force-pushed
the
quick-actions-refactoring
branch
4 times, most recently
from
d9652c9
to
635a43a
Compare
peter-sanderson
force-pushed
the
quick-actions-refactoring
branch
2 times, most recently
from
e00ccc9
to
11d8db0
Compare
2 tasks
…adding a update icon chore(components): add frameProps for ComponentWithSubIcon
peter-sanderson
force-pushed
the
quick-actions-refactoring
branch
from
11d8db0
to
17a4762
Compare
|
QA NOK see Trezor icon its not properly aligned in white square 
Info:
|
|
@bosomt Interesting, nice catch. Hovever its not happening to me on Linux & Desktop. I have asked somebody with Mac to investigate. |
|
QA OK overall it looks great, if anyone else complains about that icon i will create issue Info:
|
|
@peter-sanderson created follow up issue :) havent noticed it till now ;) #14497 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
ComponentWithIconto abstract the component with a little icon in the cornerPart of the #13990