Skip storing draft in RBF form, reintroduce precomposedForm #15402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
komret
force-pushed
the
fix/reintroduce-precomposed-form
branch
from
3a15a9f
to
6a0e0f8
Compare
|
🚀 Expo preview is ready!
|
komret
force-pushed
the
fix/reintroduce-precomposed-form
branch
from
6a0e0f8
to
40cdcd5
Compare
|
This PR do no harm to the mobile implementation. Only what changes for us is that there will be an extra attribute in the redux state, but we do not interact with it in any way. So feel free to merge this change. I tested your branch locally on mobile and it works as expected 👌. |
PeKne
reviewed
Nov 15, 2024
| @@ -36,7 +36,7 @@ import { findLabelsToBeMovedOrDeleted, moveLabelsForRbfAction } from '../moveLab | |||
| export const MODULE_PREFIX = '@send'; | |||
|
|
|||
| export const saveSendFormDraftThunk = createThunk( | |||
| `${MODULE_PREFIX}/saveSendFormDraftThunk`, | |||
| `${MODULE_PREFIX}/ `, | |||
There was a problem hiding this comment.
This is probably not intentional
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
RBF form should not store transaction drafts. It creates confusion when send form is opened with unexpected pre-filled data and also causes errors when a transaction is created in thusly affected send form.
This PR reintroduces
precomposedFormwhich holds similar data as drafts, but is used by both send form and RBF form synchronize data between the form and the review modal.These changes may affect the mobile app.
Related Issue
Resolve #13325
Resolve #14753 (create a transaction, , open RBF form, replace the transaction, go to send form, try to send)
Resolve #15114 (create a transaction, open RBF form, close it without replacing the transaction, go to send form, try to send)