Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

connect - popup might not be needed #14527

Open
mroz22 opened this issue Sep 25, 2024 · 2 comments
Open

connect - popup might not be needed #14527

mroz22 opened this issue Sep 25, 2024 · 2 comments
Assignees
@martykan
Labels
connect Connect API related (ie. fee calculation)

Comments

@mroz22
Copy link
Contributor

mroz22 commented Sep 25, 2024 •
edited
Loading

Consider not opening the connect-popup if we can tell beforehand that we won't need it.

unskip skipped test in #14517
@mroz22 mroz22 added the connect Connect API related (ie. fee calculation) label Sep 25, 2024
@martykan martykan self-assigned this Sep 25, 2024
@Hannsek
Copy link
Contributor

Hannsek commented Sep 25, 2024

In which situation we currently open popup when we don't need it?

@martykan
Copy link
Member

For example getFeatures for an already remembered device with granted permissions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@martykan martykan

Labels
connect Connect API related (ie. fee calculation)
Projects
Issues Suite
Status: 🎯 To do
Milestone
No milestone
Development

No branches or pull requests
3 participants
@martykan @mroz22 @Hannsek