Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cancel from host - meta issue #14507

Closed
mroz22 opened this issue Sep 24, 2024 · 0 comments · Fixed by #13925
Closed

cancel from host - meta issue #14507

mroz22 opened this issue Sep 24, 2024 · 0 comments · Fixed by #13925
Labels
Bridge -> nodeUSB bug Something isn't working as expected QA Quality assurance related

Comments

@mroz22
Copy link
Contributor

mroz22 commented Sep 24, 2024

Cancel from host

lets finally fix it everywhere

There are a couple of button requests that may be cancelled from the host:

  • common button request (eg get address), basically whatever "confirm on device"
  • passphrase
  • pin (t1)
image

All of these should have a cancel button available somewhere in UI.

As @szymonlesisz found, it didn't always work correctly and prepared a fix in #13925

please let's test the following matrix:

Webusb bridge 2.0.27 * bridge 2.0.33 bridge 3+
get address
pin T1
passphrase
  • here you will likely not see cancel buttons in Suite.

Also please check these issues - they may be affected by the fix as well:

@mroz22 mroz22 added bug Something isn't working as expected QA Quality assurance related Bridge -> nodeUSB labels Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bridge -> nodeUSB bug Something isn't working as expected QA Quality assurance related
Projects
Status: 🤝 Needs QA
Development

Successfully merging a pull request may close this issue.

1 participant