transport bridge UI #12050
Merged
transport bridge UI #12050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroz22
force-pushed
the
transport-bridge-ui
branch
from
5fdca91
to
869c8de
Compare
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. |
mroz22
force-pushed
the
transport-bridge-ui
branch
2 times, most recently
from
2ff0ca6
to
2734383
Compare
komret
approved these changes
Apr 18, 2024
| return 'Trezor model T/R Bootloader'; | ||
| case 5: | ||
| return 'Emulator'; | ||
| default: |
There was a problem hiding this comment.
nit: I would prefer to have it strict mapping without having default case
|
|
||
| const { ext } = path.parse(pathname); | ||
|
|
||
| fs.exists(pathname, function (exist) { |
There was a problem hiding this comment.
nit: arrow function? I think we use (prefer) them everywhere
| if (fs.statSync(pathname).isDirectory()) pathname += '/index' + ext; | ||
|
|
||
| // read file from file system | ||
| fs.readFile(pathname, function (err, data) { |
There was a problem hiding this comment.
nit: arrow function? I think we use (prefer) them everywhere
mroz22
force-pushed
the
transport-bridge-ui
branch
from
2734383
to
bc4e355
Compare
|
forced pushed the nitpicks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bridge-node status page
part of #11532
Features:
Todo: