Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode is not selected as default even though the system is enabled for dark mode by default. #10643

Closed
mnuky opened this issue Jan 12, 2024 · 2 comments · Fixed by #11987
Closed

Dark mode is not selected as default even though the system is enabled for dark mode by default. #10643

mnuky opened this issue Jan 12, 2024 · 2 comments · Fixed by #11987
Assignees
@vytick
Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs

Comments

@mnuky
Copy link

mnuky commented Jan 12, 2024 •
edited by PeKne
Loading

Steps to reproduce:

  1. Set the dark mode as default in your mobile system (Android!)
  2. Open the app
  3. App does not reflect it

Corrent behaviour: app should respect the settings when colour mode is set to "system"
@mnuky mnuky converted this from a draft issue Jan 12, 2024
@mnuky mnuky removed this from Issues Suite Jan 12, 2024
@mnuky mnuky added mobile Suite Lite issues and PRs bug Something isn't working as expected labels Jan 12, 2024
@mnuky mnuky moved this to 🎯 To do in Suite Mobile Jan 16, 2024
@PeKne PeKne self-assigned this Jan 17, 2024
@PeKne PeKne moved this from 🎯 To do to 🏃‍♀️ In progress in Suite Mobile Jan 17, 2024
@PeKne
Copy link
Contributor

PeKne commented Jan 17, 2024 •
edited
Loading

I wasn't able the find a quick fix for this issue. The react-native. Appearance.useColorScheme hook always returns light in the Android version of the app.

According to multiple sources, there should be an easy way to fix this issue by following this tutorial. Unfortunately, it works only for expo apps. Since this is a low-priority issue and we are planning to migrate to the expo soon, I will revisit this issue then.

@PeKne PeKne removed their assignment Jan 17, 2024
@PeKne PeKne moved this from 🏃‍♀️ In progress to 🎯 To do in Suite Mobile Jan 17, 2024
@vytick vytick mentioned this issue Apr 11, 2024
Merged
@vytick vytick moved this from 🎯 To do to 🔎 Needs review in Suite Mobile Apr 11, 2024
@vytick vytick self-assigned this Apr 11, 2024
@github-project-automation github-project-automation bot moved this from 🔎 Needs review to 🤝 Needs QA in Suite Mobile Apr 12, 2024
@bosomt
Copy link
Contributor

bosomt commented Apr 18, 2024

QA OK

app starts in dark mode when started for first time or after storage is wiped

  • version 24.4.0 3550932
  • Android 14 , Nothing phone 1

@bosomt bosomt moved this from 🤝 Needs QA to ✅ Approved in Suite Mobile Apr 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@vytick vytick

Labels
bug Something isn't working as expected mobile Suite Lite issues and PRs
Projects
Suite Mobile
Status: ✅ Approved
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(suite-native): fix reading system color scheme trezor/trezor-suite
4 participants
@vytick @PeKne @bosomt @mnuky