Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

new version to npm #12

Open
demmer opened this issue Mar 11, 2015 · 5 comments
Open

new version to npm #12

demmer opened this issue Mar 11, 2015 · 5 comments

Comments

@demmer
Copy link
Contributor

demmer commented Mar 11, 2015

Can you please publish a new version to npm since I'd like to be able to run with the fix from 73719b0.

Thanks!

@joeyhub
Copy link

joeyhub commented Apr 16, 2015

Same here but I'm not fond of this fix.

Surely it should just need a return statement in the catch.

    if (!dobj.val)
            return null;

This could be changed to throw. Part of the problem here is inconsistency (protocol throws TypeError but query returns null).

Any kind of unhandled error though should just be a fatal one. Hiding application errors is how hacks happen or how bugs just get hidden away.

I would suggest something like an instanceof check. For example, if(e instanceof ExpectedError)emit else throw(e)...

Though I don't really know the best way in JS to really achieve that.

Anyway, even if the fix is imperfect we still need this in npm. It's a critical problem. My daemon is constantly going down because of this. You can knock it out by just sending anything random to the UDP port.

@derhuerst
Copy link

bump.

@h43z
Copy link

h43z commented Nov 12, 2018

bump :P

@Saiv46
Copy link

Saiv46 commented Mar 6, 2019

Bump

@ghost
Copy link

ghost commented Apr 24, 2020

bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants