-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new version to npm #12
Comments
Same here but I'm not fond of this fix. Surely it should just need a return statement in the catch.
This could be changed to throw. Part of the problem here is inconsistency (protocol throws TypeError but query returns null). Any kind of unhandled error though should just be a fatal one. Hiding application errors is how hacks happen or how bugs just get hidden away. I would suggest something like an instanceof check. For example, if(e instanceof ExpectedError)emit else throw(e)... Though I don't really know the best way in JS to really achieve that. Anyway, even if the fix is imperfect we still need this in npm. It's a critical problem. My daemon is constantly going down because of this. You can knock it out by just sending anything random to the UDP port. |
bump. |
bump :P |
Bump |
bump |
Can you please publish a new version to npm since I'd like to be able to run with the fix from 73719b0.
Thanks!
The text was updated successfully, but these errors were encountered: