Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

4.12.0 release #145

Closed
merces opened this issue Sep 18, 2024 · 6 comments
Closed

4.12.0 release #145

merces opened this issue Sep 18, 2024 · 6 comments
Labels
Milestone

Comments

@merces
Copy link
Member

merces commented Sep 18, 2024

@jonjoliver Opening up this for discussion. Any other issues on the list we should tackle before 4.12.0 release?

@merces merces mentioned this issue Sep 18, 2024
@merces merces added this to the 4.12.0 milestone Sep 18, 2024
@jonjoliver
Copy link
Collaborator

Hi @merces

I previously did a release which had quite a lot of fixes in it.
That release was questioned by I think 2 people who requested that changes come in smallish packages.
That way they can check the change - and merge it into their version - or reject the change as not being relevant to them.

Lets look at issues / pull requests we can put together (especially if they are related), but avoid creating a monster release.

Cheers jono

@jonjoliver
Copy link
Collaborator

Lets create a release for 4.12.0 as it exists today - the README.md / Change_History.md / version numbers in CMakeLists.txt are consistent with the code.

Lets put the following in a 4.12.1
Remove call to sprintf() to avoid warnings #146
py_ext: use PyVarObject_HEAD instead of PyObject_HEAD_INIT #141
Build: Define default options only on "default"#138
Bug Fix+Portability: Improve portability by integral division #136

@jonjoliver
Copy link
Collaborator

If we agree with the 4.12.1 list then I will modify README.md / Change_History.md / version numbers in CMakeLists.txt to document that.

@merces
Copy link
Member Author

merces commented Sep 19, 2024

Sure, sounds good to me!
I've already renamed the milestone to 4.12.1 and added the PRs from your list to it. ;)

@sunxingxing
Copy link

Sure, sounds good to me! I've already renamed the milestone to 4.12.1 and added the PRs from your list to it. ;)

So could you make a tag of 4.12.0 or make it a released version.

@merces
Copy link
Member Author

merces commented Oct 4, 2024

@sunxingxing v4.12.0 is out! :) thanks @jonjoliver!

@merces merces closed this as completed Oct 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants