Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The common pear is listed as not edible, with edible_part=null #68

Open
JackieCalapristi opened this issue Oct 11, 2020 · 0 comments
Open
Assignees
Labels
data-integrity Relative to the data quality

Comments

@JackieCalapristi
Copy link

JackieCalapristi commented Oct 11, 2020

Describe the bug
The common pear is listed as not edible and edible_part=null under the species endpoint. I assume this is listed as not edible correctly because pear trees aren't edible, but pears are, which makes me think that edible_part should list "fruits" instead of null. If these are all false assumptions, maybe updating the documentation to explain this (i.e. edible refers to the entire plant, even if the common name refers to the fruit) would be helpful? I thought about submitting a correction in a POST request, but I wasn't sure if this was actually an accurate error or not because I'm definitely not a plant expert.

To Reproduce
Steps to reproduce the behavior:
Make a get request to https://trefle.io/api/v1/species/172991/?token=<your_token> and note values for edible and edible_part for the common pear.

Expected behavior
To see that edible_part listed "fruits" instead of null in the response body.

Screenshots
Screen Shot 2020-10-10 at 5 17 29 PM

Additional context
If my assumptions here are correct, I've noticed the same thing for other plants (corn, for example) and would be happy to submit POST requests to correct these as I see them. Thanks so much in advance!

@JackieCalapristi JackieCalapristi added the bug Something isn't working label Oct 11, 2020
@lambda2 lambda2 added data-integrity Relative to the data quality and removed bug Something isn't working labels Oct 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-integrity Relative to the data quality
Projects
None yet
Development

No branches or pull requests

2 participants