Pull speed restrictions data from DynamoDB #714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
idreyn
requested review from
austinjpaul,
skaplan-dev,
devinmatte and
PatrickCleary
as code owners
github-actions
bot
added
backend
devinmatte
approved these changes
Jul 5, 2023
| window.location.origin | ||
| ); | ||
| return fetch(speed_restrictions_url.toString()).then((resp) => resp.json()); | ||
| const today = new Date(); |
There was a problem hiding this comment.
So this may cause issues after 8pm EST as it'll be tomorrow in GMT. I think we try to use dayJs dates throughout the code to avoid this
There was a problem hiding this comment.
That's a good callout but in this case we're never going to display the date, we just treat it as a timestamp.
PatrickCleary
approved these changes
Jul 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In transitmatters/data-ingestion#26 I added the MBTA's data on track speed restrictions to our DynamoDB tables. This PR updates the DD's speed restriction info to query from that table. It ultimately goes here, in the SZ map tooltip: