You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I originally used this component because I wanted good arrow key support in this menu — but I'm finding:
It's slow
It's forcing us to write unidiomatic React — checking data-id attributes on divs!
It actually breaks keyboard users' expectations of being able to tab through the list.
So let's remove it — probably we embed an onClick handler inside of <StationName> and, when that's available, use a Reakit <Button> inside of <StationName>? There may also be some aria attributes we can add to this component to retain the semantic flavor of "a list of selectable items".
Also note that when we make this change we should make the <StationName> tooltip focusable with:
I originally used this component because I wanted good arrow key support in this menu — but I'm finding:
data-id
attributes on divs!So let's remove it — probably we embed an
onClick
handler inside of<StationName>
and, when that's available, use a Reakit<Button>
inside of<StationName>
? There may also be some aria attributes we can add to this component to retain the semantic flavor of "a list of selectable items".Also note that when we make this change we should make the
<StationName>
tooltip focusable with:The text was updated successfully, but these errors were encountered: