Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding Green line train tracking to new trains #40

Merged
merged 5 commits into from
Oct 11, 2023
Merged

Adding Green line train tracking to new trains #40

merged 5 commits into from
Oct 11, 2023

Conversation

devinmatte
Copy link
Member

@devinmatte devinmatte commented Jul 31, 2023 •
edited
Loading

Tracking Green line trains as new trains
#39

Also adds a list of vehicle ids for the day

@devinmatte devinmatte requested a review from austinjpaul as a code owner July 31, 2023 23:03
@devinmatte devinmatte marked this pull request as draft August 1, 2023 00:19
@devinmatte devinmatte marked this pull request as ready for review October 10, 2023 20:33
@devinmatte devinmatte requested a review from mathcolo October 10, 2023 20:34
This was linked to issues Oct 11, 2023
newtrains: store total runs #3
Open
NewTrains should track Green line trains #39
Closed
@nathan-weinberg nathan-weinberg self-requested a review October 11, 2023 01:43
nathan-weinberg
nathan-weinberg approved these changes Oct 11, 2023
View reviewed changes
Copy link
Member

@nathan-weinberg nathan-weinberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Am not super familiar with the ingestor code but Pythonically everything LGTM - feel free to wait for other reviews or just go ahead and merge if you're confident 😄

@devinmatte devinmatte merged commit 0fd3d46 into main Oct 11, 2023
1 check passed
@devinmatte devinmatte deleted the green-line-new-trains branch October 11, 2023 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathan-weinberg nathan-weinberg nathan-weinberg approved these changes

@austinjpaul austinjpaul Awaiting requested review from austinjpaul austinjpaul is a code owner

@mathcolo mathcolo Awaiting requested review from mathcolo

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

newtrains: store total runs NewTrains should track Green line trains
2 participants
@devinmatte @nathan-weinberg