Skip to content
This repository has been archived by the owner on Sep 23, 2024. It is now read-only.

Bit types of length > 1 not being detected #104

Open
jmriego opened this issue Jul 14, 2021 · 1 comment
Open

Bit types of length > 1 not being detected #104

jmriego opened this issue Jul 14, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@jmriego
Copy link

jmriego commented Jul 14, 2021

Describe the bug
Bit types of length > 1 not being detected

To Reproduce
create a table with a BIT(8) field:

create table jmtest (
id INTEGER,
name VARCHAR,
somebytes bit(8),
etl_updated_timestamp TIMESTAMP);

Run tap in discover mode:
tap-postgres --config ~/.pipelinewise/bigquery/tap_jmtest/config.json --discover

Expected behavior
We should see the type of the somebytes column. Instead we are getting empty type for this column

Screenshots
image

Your environment

  • Version of tap: 1.8.0
  • Version of python 3.7.7

Additional context
This is related to the issue in the main repo: transferwise/pipelinewise#740
It seems to affect all targets and also in a different way this PostgreSQL tap

@jmriego jmriego added the bug Something isn't working label Jul 14, 2021
@Samira-El
Copy link
Contributor

Hey @jmriego,

Bit columns of length > 1 are not currently supported and thus ignored during discovery and sync, see

def schema_for_column_datatype(col):

It would be cool to add support for it tho, and we're open to reviewing a PR if you can work on it.

@Samira-El Samira-El added enhancement New feature or request and removed bug Something isn't working labels Nov 2, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants