Skip to content

Commit c36aff4

Browse files
committed
Add a test for movies with same name
See for e.g. #480
1 parent e78d536 commit c36aff4

4 files changed

+94
-0
lines changed
+38
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,38 @@
1+
[
2+
{
3+
"imdbnumber": "116853",
4+
"movieid": 781,
5+
"runtime": 5220,
6+
"title": "The Bling Ring",
7+
"userrating": 0,
8+
"year": 2011,
9+
"watched_at": "",
10+
"collected_at": "2024-05-29T22:01:43+00:00",
11+
"plays": 0,
12+
"rating": 0,
13+
"collected": 1,
14+
"watched": 0,
15+
"ids": {
16+
"imdb": "tt1935749",
17+
"tmdb": "116853"
18+
}
19+
},
20+
{
21+
"imdbnumber": "96936",
22+
"movieid": 782,
23+
"runtime": 5400,
24+
"title": "The Bling Ring",
25+
"userrating": 0,
26+
"year": 2013,
27+
"watched_at": "",
28+
"collected_at": "2024-05-29T22:01:43+00:00",
29+
"plays": 0,
30+
"rating": 0,
31+
"collected": 1,
32+
"watched": 0,
33+
"ids": {
34+
"imdb": "tt2132285",
35+
"tmdb": "96936"
36+
}
37+
}
38+
]
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
[
2+
{
3+
"imdbnumber": "116853",
4+
"movieid": 781,
5+
"runtime": 5220,
6+
"title": "The Bling Ring",
7+
"userrating": 0,
8+
"year": 2011,
9+
"watched_at": "",
10+
"collected_at": "2024-05-29T22:01:43+00:00",
11+
"plays": 0,
12+
"rating": 0,
13+
"collected": 1,
14+
"watched": 0,
15+
"ids": {
16+
"imdb": "tt1935749",
17+
"tmdb": "116853"
18+
}
19+
}
20+
]
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,20 @@
1+
[
2+
{
3+
"imdbnumber": "96936",
4+
"movieid": 782,
5+
"runtime": 5400,
6+
"title": "The Bling Ring",
7+
"userrating": 0,
8+
"year": 2013,
9+
"watched_at": "",
10+
"collected_at": "2024-05-29T22:01:43+00:00",
11+
"plays": 0,
12+
"rating": 0,
13+
"collected": 1,
14+
"watched": 0,
15+
"ids": {
16+
"imdb": "tt2132285",
17+
"tmdb": "96936"
18+
}
19+
}
20+
]

tests/test_utilities.py

+16
Original file line numberDiff line numberDiff line change
@@ -267,6 +267,22 @@ def test_sanitizeMovies_userrating():
267267
assert not result
268268

269269

270+
def test_compareMovies_matchByTitleAndYear_titles_with_same_name_for_collection():
271+
data1 = load_params_from_json("tests/fixtures/movies_local_same_name.json")
272+
273+
assert utilities.compareMovies(data1, "", True) == data1
274+
275+
276+
def test_compareMovies_matchByTitleAndYear_titles_with_same_name_for_collection_one_already_collected():
277+
data1 = load_params_from_json("tests/fixtures/movies_local_same_name.json")
278+
data2 = load_params_from_json("tests/fixtures/movies_local_same_name_2.json")
279+
result_json = load_params_from_json(
280+
"tests/fixtures/movies_local_same_name_result.json"
281+
)
282+
283+
assert utilities.compareMovies(data1, data2, True) == result_json
284+
285+
270286
def test_compareMovies_matchByTitleAndYear_collected_match():
271287
data1 = load_params_from_json("tests/fixtures/movies_local.json")
272288
data2 = load_params_from_json("tests/fixtures/movies_remote.json")

0 commit comments

Comments
 (0)