Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stock price forecasting demo #79

Open
JustinShenk opened this issue Apr 1, 2021 · 6 comments
Open

Stock price forecasting demo #79

JustinShenk opened this issue Apr 1, 2021 · 6 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@JustinShenk
Copy link
Collaborator

JustinShenk commented Apr 1, 2021

Demonstrate Traja with a stock market price forecasting example.

Good place to start is the Colab notebook: https://colab.research.google.com/github/justinshenk/traja/blob/master/demo.ipynb

@JustinShenk JustinShenk added good first issue Good for newcomers enhancement New feature or request labels Apr 1, 2021
@Justus-M Justus-M self-assigned this Apr 1, 2021
@JustinShenk
Copy link
Collaborator Author

The model tests provide a good starting point for how to use the API.

@Justus-M
Copy link

Justus-M commented Apr 10, 2021

@JustinShenk is Traja currently limited to predicting all the input variables, or is there a way to pass specific endpoints or select a subset of inputs for prediction?

Ex. for this stock market price forecasting use case you would want to use (at least) volume, open, close and price as inputs, and then predict only the price.

@Saran-nns Saran-nns self-assigned this Apr 12, 2021
@Saran-nns
Copy link
Member

Saran-nns commented Apr 12, 2021

Yes,currently Traja doesn't support user specified variable prediction. dataset.MultiModalDataLoader, consider all features except 'ID' as time series and forecast/predict all time series variables 'k' steps forward.

Yes, by f:R^n-->R^m where m<<n, we can exploit traja models and ripe better predictive performance.

A simple work around is to

  1. Add arg in MultiModalDataLoader to accept list of target_vars with assert output_dim==len(target_vars) in generate_dataset method
  2. Override the targets here

Thanks for the issue.

@JustinShenk
Copy link
Collaborator Author

@Justus-M does this look like something you could help with?

@Justus-M
Copy link

Justus-M commented Jan 28, 2022

Hi guys, sorry I never followed up on this. I did immediately spend some time looking at the documentation to try and implement this. I couldn't get it to run, and as my Pytorch experience is limited (I'm used to TensorFlow) it just ended up being much more time-consuming than initially expected, so I decided not to continue as it wasn't a priority and I have a lot on my plate at the moment.

I've uploaded some high resolution (minute level) long term apple stock price data, in case someone from the Traja team would like to test it themselves:
https://drive.google.com/file/d/15Lhx9Txmxz7xvM0rFJ4HvMBwkUvdwyhB/view?usp=sharing

@JustinShenk
Copy link
Collaborator Author

JustinShenk commented Jan 30, 2022 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

3 participants