Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename/alias eqv to equivalent #2

Open
maiermic opened this issue Jan 5, 2016 · 3 comments
Open

rename/alias eqv to equivalent #2

maiermic opened this issue Jan 5, 2016 · 3 comments

Comments

@maiermic
Copy link

maiermic commented Jan 5, 2016

All methods on the Trait interface are self-explaining thanks to full words instead of abbreviations. The only exception is eqv. I suggest to rename eqv to equivalent. Thus, the interface would be consistent. You can keep eqv as deprecated alias to be backward compatible.

@dotnetCarpenter
Copy link
Member

@maiermic I don't think that eqv should be deprecated but making equivalent an alias for eqv is a good idea and could be in a minor release.

@maiermic
Copy link
Author

maiermic commented Jan 9, 2016

@dotnetCarpenter My intention is to point out to users of traits.js to prefer equivalent to eqv. If I'm not mistaken, deprecating is a common practice even for method naming:

Since merely renaming an item would break backwards compatibility, the existing name must be left in place. The original name will likely remain indefinitely, but will be deprecated to encourage use of the newer, more consistent naming convention.
Software deprecation - Wikipedia

@dotnetCarpenter
Copy link
Member

@maiermic If you want to write equivalent to achieve better readability, I'm all for it. But I for one will not use it, since English is not my first language and equivalent doesn't give me anything oppose to eqv, which I find easier to spell and remember. So I won't deprecate eqv.

What I'm trying to say is that I will add the alias but it is very low on my priority list. If you want to add it, you're welcome to create a PR. If not, then I will add it eventually.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants