From 8f11388ad35edda2255b02c0b27b2eccc5b8882b Mon Sep 17 00:00:00 2001 From: Sebastian Gatscha Date: Wed, 13 Apr 2022 20:33:14 +0200 Subject: [PATCH] fix tests --- R/daterangepicker.R | 10 +++--- tests/testthat/test-daterangepicker.R | 50 +++++++++++++-------------- 2 files changed, 30 insertions(+), 30 deletions(-) diff --git a/R/daterangepicker.R b/R/daterangepicker.R index 008743d..6203643 100644 --- a/R/daterangepicker.R +++ b/R/daterangepicker.R @@ -9,11 +9,11 @@ #' @family perioddaterangepicker Functions #' @export updatePerioddaterangepicker <- function(session, inputId, label = NULL, - start = NULL, end = NULL, - min = NULL, max = NULL, - icon = NULL, options = NULL, - ranges = NULL, style = NULL, - class = NULL) { + start = NULL, end = NULL, + min = NULL, max = NULL, + icon = NULL, options = NULL, + ranges = NULL, style = NULL, + class = NULL) { ## If no icon was passed initially, we need to create a WebDependency-list ## On the JS-side `Shiny.renderDependencies` adds the deps to the header diff --git a/tests/testthat/test-daterangepicker.R b/tests/testthat/test-daterangepicker.R index 3e949f2..676c733 100644 --- a/tests/testthat/test-daterangepicker.R +++ b/tests/testthat/test-daterangepicker.R @@ -142,31 +142,31 @@ test_that("perioddaterangepicker", { expect_length(object = htmltools::findDependencies(x), n = 1) ## Updates ######################### - # session <- as.environment(list( - # ns = identity, - # sendInputMessage = function(inputId, message) { - # session$lastInputMessage = list(id = inputId, message = message) - # } - # )) - - # updateDaterangepicker(session, "daterange", label = "NewLabel", - # start = start, end = end) - # res <- session$lastInputMessage - # expect_identical(res$message$id, "daterange") - # expect_identical(res$message$label, "NewLabel") - # expect_identical(res$message$start, start) - # expect_identical(res$message$end, end) - # - # updateDaterangepicker(session, "daterange", label = "NewLabel", - # start = start, end = end, icon = icon("calendar")) - # res <- invisible(session$lastInputMessage) - # expect_identical(res$message$id, "daterange") - # expect_identical(res$message$label, "NewLabel") - # expect_identical(res$message$start, start) - # expect_identical(res$message$end, end) - # expect_is(res$message$icon, "shiny.tag") - # expect_is(res$message$icon$htmldeps[[1]], "html_dependency") - # expect_length(res$message$icon$htmldeps[[1]], 9) + session <- as.environment(list( + ns = identity, + sendInputMessage = function(inputId, message) { + session$lastInputMessage = list(id = inputId, message = message) + } + )) + + updatePerioddaterangepicker(session, "daterange", label = "NewLabel", + start = start, end = end) + res <- session$lastInputMessage + expect_identical(res$message$id, "daterange") + expect_identical(res$message$label, "NewLabel") + expect_identical(res$message$start, start) + expect_identical(res$message$end, end) + + updatePerioddaterangepicker(session, "daterange", label = "NewLabel", + start = start, end = end, icon = icon("calendar")) + res <- invisible(session$lastInputMessage) + expect_identical(res$message$id, "daterange") + expect_identical(res$message$label, "NewLabel") + expect_identical(res$message$start, start) + expect_identical(res$message$end, end) + expect_is(res$message$icon, "shiny.tag") + expect_is(res$message$icon$htmldeps[[1]], "html_dependency") + expect_length(res$message$icon$htmldeps[[1]], 9) ## onLoad ####################### expect_null(perioddaterangepicker:::.onLoad()(NULL))