Allow extending env value more easily

[jnoordsij]

Welcome!

• Yes, I've searched similar issues on GitHub and didn't find any.
• Yes, I've searched similar issues on the Traefik community forum and didn't find any.

What did you expect to see?

Currently the env key in the values file is a list. This means that it is not easily extendable, since Helm will overwrite list values when set, rather than merging them. This means that when one wants to pass an additional env variable, e.g. TZ=US/Alaska, the entire list contained in this repo has to be copied and passed with it, or else will get lost:

  env:
    # This has to be copied (current values.yaml content)
    - name: POD_NAME
      valueFrom:
        fieldRef:
          fieldPath: metadata.name
    - name: POD_NAMESPACE
      valueFrom:
        fieldRef:
          fieldPath: metadata.namespace
    # Custom additions can then be placed afterwards
    - name: TZ
      value: US/Alaska

It would be nice to have another value type, e.g. key-based, for the environment, so Helm can properly merge it. This can then be parsed into the correct format within the relevant templates.

Suggested implementation: the approach on the following StackExchange question might be a good place to start:
https://stackoverflow.com/questions/59394422/helm-charts-with-multiple-lists-in-multiple-values-files

[mloiseleur]

\o Yes you're right !
We didn't think about it when we added those two fields.

[lusson-luo]

@mloiseleur

so, what is next, values.yaml add two env config, default_env and custom_env?default_env include POD_NAME and POD_NAMESPACE

[mloiseleur]

@lusson-luo The next step is to open a PR to fix this issue. @jnoordsij shared a stackoverflow link with what seems an easy way to fix it.

[shubhamch71]

@mloiseleur Is this issue still open to work on??

[mloiseleur]

Yes it is