Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature flag for opt-in/opt-out of checked launches #266

Open
torsteingrindvik opened this issue Nov 16, 2024 · 2 comments
Open

Feature flag for opt-in/opt-out of checked launches #266

torsteingrindvik opened this issue Nov 16, 2024 · 2 comments

Comments

@torsteingrindvik
Copy link
Contributor

Add a feature flag to either opt-in to checked kernel launches, or a feature flag to opt-in to unchecked kernel launches.
Whichever makes most sense for the end user.

@torsteingrindvik
Copy link
Contributor Author

Some context from discord: https://discordapp.com/channels/1038839012602941528/1091796857996451942/1307410785190019163

@nathanielsimard :

Also, we could have a feature flag on CubeCL disabling unchecked no matter what

Could you elaborate a bit on what you'd like to have?

Do you mean a feature flag e.g.

#[features]
checked-launches = []

which if turned on adds checking?

And if so I take it there should only exist #[cube(launch)] and the feature flag decides the check behaviour.

If I know what's desired I might contribute a PR for it

@nathanielsimard
Copy link
Member

I would say more like:

force-checked = []

And in the client, always pass ExecutionMode::Checked even when calling unchecked.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants