Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor for wgpu v23 compatibility #2435

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

Refactor for wgpu v23 compatibility #2435

wants to merge 15 commits into from

Conversation

AsherJingkongChen
Copy link
Contributor

@AsherJingkongChen AsherJingkongChen commented Oct 29, 2024 •
edited
Loading

Checklist

  • Confirmed that run-checks all script has been executed.
  • Made sure the book is up to date with changes in this PR.
    • After this PR merged, contributor-book/src/guides/adding-a-new-operation-to-burn.md needs to be updated.
  • Check dependencies.

Related Issues/PRs

Close #2451

Changes

Testing

(Solved): I run ./run-checks.sh all, but too many errors occurred on macOS (Metal) 🥺. Fixing the bugs ...

@AsherJingkongChen AsherJingkongChen mentioned this pull request Oct 29, 2024
Merged
3 tasks
@codecov Codecov
Copy link

codecov bot commented Oct 29, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 81.86%. Comparing base (6dbc3fd) to head (9ac5a3d).

Files with missing lines Patch % Lines
crates/burn-tensor/src/lib.rs 0.00% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #2435   +/-   ##
=======================================
  Coverage   81.86%   81.86%           
=======================================
  Files         833      833           
  Lines      106449   106448    -1     
=======================================
  Hits        87146    87146           
+ Misses      19303    19302    -1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AsherJingkongChen
Update CubeCL
615c174 
* The comments in `WgpuDevice::id()` are removed since `id` in `WgpuDevice::Existing` is always `u32`
@AsherJingkongChen
Copy link
Contributor Author

AsherJingkongChen commented Oct 29, 2024 •
edited
Loading

Discovery

The least recent version of wgpu that breaks burn-wgpu tests on Metal is found, see gfx-rs/wgpu@9c781d6.

@AsherJingkongChen

This comment has been minimized.

Sign in to view
@AsherJingkongChen AsherJingkongChen mentioned this pull request Nov 1, 2024
Open
2 tasks
@AsherJingkongChen
Copy link
Contributor Author

AsherJingkongChen commented Nov 12, 2024 •
edited
Loading

Status Update

Currently, I am busy working at my personal projects. I would run CI every one or two weeks.

It seems that there are more errors occurred on macOS. I would resolve them after I finish my own works.

ArthurBrussee added a commit to ArthurBrussee/brush that referenced this pull request Nov 14, 2024
@ArthurBrussee
Disable SSIM on wasm for now
278091c 
SSIM on wasm causes bad glitches. I suspect it's related to tracel-ai/burn#2435, but hard to say.
@ArthurBrussee ArthurBrussee mentioned this pull request Nov 14, 2024
Merged
ArthurBrussee added a commit to ArthurBrussee/brush that referenced this pull request Nov 14, 2024
@ArthurBrussee
Disable SSIM on wasm for now (#31)
4008571 
SSIM on wasm causes bad glitches. I suspect it's related to tracel-ai/burn#2435, but hard to say.
@ArthurBrussee ArthurBrussee mentioned this pull request Nov 22, 2024
Merged
@AsherJingkongChen

This comment has been minimized.

Sign in to view
@AsherJingkongChen

This comment has been minimized.

Sign in to view
@ArthurBrussee
Copy link
Contributor

That's awesome! Thanks for checking again :) I think the remaining errors are the same as here: #2539

The deformable convolutions might need some attention from Genna, for the others, maybe @nathanielsimard knows?

@AsherJingkongChen AsherJingkongChen marked this pull request as ready for review December 5, 2024 05:22
@AsherJingkongChen AsherJingkongChen marked this pull request as draft December 5, 2024 08:30
@AsherJingkongChen
Copy link
Contributor Author

AsherJingkongChen commented Dec 5, 2024 •
edited
Loading

It just passed CI 20 hours ago ... And macOS failed at 110+ tests?

I think I am using the right CubeCL version.

https://github.com/tracel-ai/cubecl/compare/1c4e0036c043422773fd6824c2a888160fca8e5e..13fc62c22f311d2d153abbc4ffb4ef5271bc82a3

@AsherJingkongChen AsherJingkongChen marked this pull request as ready for review December 25, 2024 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Proper bounds checking for CubeCL kernels in Burn crates
2 participants
@AsherJingkongChen @ArthurBrussee