Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper bounds checking for CubeCL kernels in Burn crates #2451

Open
2 tasks done
AsherJingkongChen opened this issue Nov 1, 2024 · 0 comments · May be fixed by #2435
Open
2 tasks done

Proper bounds checking for CubeCL kernels in Burn crates #2451

AsherJingkongChen opened this issue Nov 1, 2024 · 0 comments · May be fixed by #2435

Comments

@AsherJingkongChen
Copy link
Contributor

AsherJingkongChen commented Nov 1, 2024

Describe the bug

Just as the title says. For details, please follow the comments under:

To Reproduce

  1. Clone or checkout the PR branch:

    a. Clone

    git clone --branch refactor/wgpu-v23 --depth 1 https://github.com/AsherJingkongChen/burn.git

    b. Checkout

    git remote add pr-2435 https://github.com/AsherJingkongChen/burn.git
    git fetch pr-2435 refactor/wgpu-v23
    git checkout -b refactor/wgpu-v23 pr-2435/refactor/wgpu-v23
  2. Run some tests on macOS with Metal:

    a. Test the specific package

    cargo test -p burn-jit

    b. Test for CI

    cargo xtask test --ci

Expected behavior

  • All errors during tests on macOS are resolved
  • Bounds checking works as expected, it is recommended to add some new tests.

Screenshots

You can check CI statuses on macOS in #2435.

Additional context

This issue blocks #2435.

@AsherJingkongChen AsherJingkongChen changed the title Proper bounds checking for CubeCL kernels Proper bounds checking for CubeCL kernels in Burn crates Nov 1, 2024
@AsherJingkongChen AsherJingkongChen linked a pull request Nov 2, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant