Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scatter_mul operation and related #2044

Open
McArthur-Alford opened this issue Jul 21, 2024 · 1 comment
Open

scatter_mul operation and related #2044

McArthur-Alford opened this issue Jul 21, 2024 · 1 comment
Assignees
Labels
feature The feature request

Comments

@McArthur-Alford
Copy link
Contributor

Feature description

It would be really nice to have a scatter_mul op, which is identical to scatter except using multiplication reduction. Similarly, scatter_max/min would be nice. There are other functions (select_assign) that could probably benefit from this as well. I suspect it might be better to have an enum for reduction strategy, rather than many functions, and just pass it as an arg to scatter?

Feature motivation

Pytorch has this functionality, so it would be nice for parity reasons.
Personally, I've wanted this a few times while working on #1998 but it isn't a pressing issue. From my looking around it seems like it would be quite a bit of work, so for now I'm not doing it myself (just making a feature request). Once I'm done with all the other sparse stuff I hope I will be able to get around to this, if it hasn't been done by then.

@antimora antimora added the feature The feature request label Jul 22, 2024
@antimora antimora changed the title Feature request: scatter_mul operation (and maybe more?) scatter_mul operation and related Jul 22, 2024
@louisfd
Copy link
Member

louisfd commented Jul 29, 2024

Hi @McArthur-Alford
I'll be working on porting both reduction kernels and scatter/select operations using CubeCL in the coming days. I'll try to think of an elegant way to generalize this.

@louisfd louisfd self-assigned this Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature The feature request
Projects
None yet
Development

No branches or pull requests

3 participants