-
Notifications
You must be signed in to change notification settings - Fork 459
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Record Deserializer
not implemented for enum
#1431
Labels
enhancement
Enhance existing features
Comments
@antimora tagging since you worked on this in the past. We can discuss this offline, would like to get your opinion. |
@laggui , yes, I agree we should support it. |
2 tasks
antimora
added a commit
to antimora/burn
that referenced
this issue
Mar 8, 2024
2 tasks
antimora
added a commit
that referenced
this issue
Mar 11, 2024
* Add Enum module support in PyTorchFileRecorder Fixes #1431 * Fix wording/typos per PR feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
I stumbled upon this issue when importing a PyTorch model with
PyTorchFileRecorder
to load it into the Burn equivalent definition.The PyTorch model defines a module that depends on a condition (returns a conv block in one case, and depthwise conv block in the other). For that, I implemented the block as an enum since #1337 landed. But it fails with this error:
Straight from
unimplemented!("deserialize_enum is not implemented")
in de.rsWould be nice to add support to deserialize with enums now that they are supported for modules.
MWE
The text was updated successfully, but these errors were encountered: