Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some test scripts missing from 1.2.0 release tarball #106

Open
rfs613 opened this issue Mar 4, 2024 · 0 comments
Open

Some test scripts missing from 1.2.0 release tarball #106

rfs613 opened this issue Mar 4, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@rfs613
Copy link

rfs613 commented Mar 4, 2024

On the github Releases page, the tpm2-openssl-1.2.0.tar.gz image [1] seems to be missing the test/digest.sh script, the test/cipher_aes128_ecb.sh script, and several more cipher tests. Curiously the github-generated tarball [2] does include these scripts. Also ,these scripts are present in previous releases like 1.1.0 and earlier.

[1] https://github.com/tpm2-software/tpm2-openssl/releases/download/1.2.0/tpm2-openssl-1.2.0.tar.gz
[2] https://github.com/tpm2-software/tpm2-openssl/archive/refs/tags/1.2.0.tar.gz

Downstream projects tend to prefer [1] over [2] because the latter may not be stable (github may decide to alter how it auto-generates these tarballs).

Presumably make dist was used to generate the [1] release image. Since commit 77218b2 the contents of this tarball will differ depending how ./configure script was executed. Although that makes sense for make install, it seems that make dist should package all the tests.

@gotthardp gotthardp added the bug Something isn't working label Mar 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants