Skip to content

Commit 2d8ea11

Browse files
committed
Do not change service_type for timer unit
1 parent 965f58c commit 2d8ea11

File tree

3 files changed

+16
-2
lines changed

3 files changed

+16
-2
lines changed

fleet/deploy/deployer.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ def __init__(self, fleet_provider, jinja_env, name,
6464
version=None, nodes=1, service_type='app',
6565
template_args=None, timer=False):
6666
self.fleet_provider = fleet_provider
67-
self.service_type = service_type
67+
self.service_type = service_type if not timer else 'app'
6868
self.nodes = nodes
6969
self.jinja_env = jinja_env
7070
self.name = name

setup.py

+1-1
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,7 @@
66
setup(
77
name='fleet-py',
88
install_requires=requirements,
9-
version='0.1.4',
9+
version='0.1.5',
1010
description='Fleet SDK Wrapper for Python',
1111
author='Sukrit Khera',
1212
author_email='',

tests/unit/deploy/test_deployer.py

+14
Original file line numberDiff line numberDiff line change
@@ -70,6 +70,20 @@ def test_init_deployment(mock_time):
7070
eq_(deployment.template_name, '[email protected]')
7171

7272

73+
def test_init_deployment_with_timer():
74+
"""
75+
Should initialize deployment instance
76+
"""
77+
78+
# When: I create a deployment instance with timer
79+
deployment = Deployment(Mock(spec=Provider), Mock(spec=Environment),
80+
'mock-app', timer=True,
81+
service_type='timer')
82+
83+
# Then: Service Type is initialized to app
84+
eq_(deployment.service_type, 'app')
85+
86+
7387
@patch('fleet.deploy.deployer.time')
7488
def test_init_timer_deployment(mock_time):
7589
"""

0 commit comments

Comments
 (0)