From ea1ba4f99f916e3dad356c87f1ed88127625793b Mon Sep 17 00:00:00 2001 From: devjojo Date: Wed, 5 Jun 2024 00:56:50 +0900 Subject: [PATCH 1/2] fix: set defaultValue to storage --- packages/react/react/src/hooks/useStorageState.ts | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/packages/react/react/src/hooks/useStorageState.ts b/packages/react/react/src/hooks/useStorageState.ts index 5c9be10ff..a89f94076 100644 --- a/packages/react/react/src/hooks/useStorageState.ts +++ b/packages/react/react/src/hooks/useStorageState.ts @@ -90,6 +90,12 @@ export function useStorageState( setState(getValue() ?? defaultValue); }, [defaultValue, getValue]); + useEffect(() => { + if (defaultValue) { + set(getValue()); + } + }, [set, getValue, defaultValue]); + return [state, set, refresh] as const; } From afe0da6c0757d5909728f1165341bc4dce7bfe8c Mon Sep 17 00:00:00 2001 From: devjojo Date: Wed, 5 Jun 2024 01:26:24 +0900 Subject: [PATCH 2/2] =?UTF-8?q?fix:=20defaultValue=20falsy=ED=95=9C=20?= =?UTF-8?q?=EA=B0=92=EC=9D=B8=20=EA=B2=BD=EC=9A=B0?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- packages/react/react/src/hooks/useStorageState.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/react/react/src/hooks/useStorageState.ts b/packages/react/react/src/hooks/useStorageState.ts index a89f94076..69f1fdf34 100644 --- a/packages/react/react/src/hooks/useStorageState.ts +++ b/packages/react/react/src/hooks/useStorageState.ts @@ -91,7 +91,7 @@ export function useStorageState( }, [defaultValue, getValue]); useEffect(() => { - if (defaultValue) { + if (defaultValue != null) { set(getValue()); } }, [set, getValue, defaultValue]);