Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should/can we pass around strings rather than soup objects? #67

Open
nickmoreton opened this issue Nov 2, 2021 · 0 comments
Open

Should/can we pass around strings rather than soup objects? #67

nickmoreton opened this issue Nov 2, 2021 · 0 comments
Labels
enhancement New feature or request

Comments

@nickmoreton
Copy link
Collaborator

The first time we get some soup is with the lxml parser.

Are you saying that the soups are different because one uses lxml and another uses html.parser? If so, then that's a strong argument for passing around string HTML objects instead of soup instances.

I favour readability and consistency at this stage, especially as we aren't yet aware of any performance concern.

Originally posted by @nimasmi in #57 (comment)

@nickmoreton nickmoreton added the enhancement New feature or request label Nov 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant